You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionList semantic github/accessibility-audits#2939 PRs were reverted because they were causing tests to fail at github/github. This PR re-introduces them (except 1 PR that is not stricken through) with some test and usage fixes required in the upstream dotcom.
1) Update PRC ActionList implementation to have similar semantics to PVC.
Deprecating ActionList.Group is not a final decision - we are exploring remediating the semantics while keeping the API the same
Deprecated ActionList.Group.
Adds ActionList.Heading to be used for labelling children in an ActionList.
2) Render ActionList.Item as button
The ActionList.Item content should render an interactive button. Exceptions are when the outermost element of the ActionList.Item is an interactive element. Examples of this include NavList (where ActionList.Items can be render as a button) and in ActionMenu, where the top-level element is made interactive with the menuitem role.
There are ActionList.Item usages that has Link component as a child. GH search (Github stuff only link) and with the new change it generates an inaccessible markup like:
<button> 👉🏻 `ActionList.Item` now is rendered as button
<a href="..."> link text </a>
</button>
I refactored these usages to use ActionList.LinkItem commit reference (GitHub stuff only link)
There are ActionList.Item usages that has role=button attribute and now ActionList.Item also returns as button, first the role attribute becomes unnecessary and it fails some tests that looks for buttons getByRole('button') because it returns multiple.GH search (Github stuff only link)
I removed the role="button" attribute from these usages.
Screenshots
Please provide before/after screenshots for any visual changes
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Context
ActionList semantic github/accessibility-audits#2939 PRs were reverted because they were causing tests to fail at github/github. This PR re-introduces them (except 1 PR that is not stricken through) with some test and usage fixes required in the upstream dotcom.
Update PRC ActionList implementation to have similar semantics to PVC. #2878NavList: Fix group dividers #3328Fix create-slots utils path in ActionList file #3223Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github #3267fix(ActionList): update to read from group context if selectionVarian… #3269Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. #3284What is changed
1) Update PRC ActionList implementation to have similar semantics to PVC.
Deprecating ActionList.Group is not a final decision - we are exploring remediating the semantics while keeping the API the same
ActionList.Group.ActionList.Headingto be used for labelling children in anActionList.2) Render ActionList.Item as
buttonThe ActionList.Item content should render an interactive button. Exceptions are when the outermost element of the ActionList.Item is an interactive element. Examples of this include NavList (where ActionList.Items can be render as a button) and in ActionMenu, where the top-level element is made interactive with the menuitem role.
github/github fixes
Integration PR: https://github.com/github/github/pull/278891
ActionList.Itemusages that hasLinkcomponent as a child. GH search (Github stuff only link) and with the new change it generates an inaccessible markup like:I refactored these usages to use
ActionList.LinkItemcommit reference (GitHub stuff only link)ActionList.Itemusages that hasrole=buttonattribute and nowActionList.Itemalso returns as button, first the role attribute becomes unnecessary and it fails some tests that looks for buttonsgetByRole('button')because it returns multiple.GH search (Github stuff only link)I removed the
role="button"attribute from these usages.Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.